added SNR lines for neighborInfo and direct routes in map

[jamon]

Initial implementation of SNR route lines (see #456 for discussion)

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Jamon Terrell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[danditomaso]

@jamon This is awesome, thanks for the submission.

[danditomaso]

I wanted to better understand where I would see the lines being drawn, I cloned your branch and opened it up. I didn't see anything connecting avatars on the Map, am I looking in the wrong place?

[jamon]

Directly attached nodes will be drawn immediately so long as your node has it's location set and you've heard from them recently.

Connections between other nodes are drawn when you see a NeighborInfo packet from them, but keep in mind that not all nodes have that turned on, and the node doesn't retain that information, so you'll only see the ones that come in while the client is connected.

We will be able to add traceroutes as a source of data in the future as well.

[danditomaso]

So some of the other app leads had a chat about this change and its awesome to see this contribution, but the new lines on the Map will need to be behind an option users can turn on and off inside the Map instead of simply applying to everyone. I think our mapping lib has an option to enable a layers selector, so this option should be added there.

[jamon]

yeah, they're already in a separate layer, so it should be pretty easy to enable/disable them. The bigger thing I think will be adding UI to allow filtering on the map--there's no filter ui at all now. It'd probably be helpful to have a few other options in there as well

• show/hide MQTT nodes
• show/hide direct connection signal lines
• show/hide indirect signal lines

It also looks like there might be some bugs in the display of the shortname on the map. Not sure if it's specific to me or not, but when you don't have node info, I'm seeing the first 4 of the mac instead of the last 4.