Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue 459 / sort direct nodes #492

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Mar 9, 2025

Description

This PR addresses the issue outlined in Issue 459 by adding another custom sort to generic Table component (similar to the preceding one in place for "Last heard".)

Related Issues

Fixes #459

Changes Made

  • Added a function to evaluate the "hopsAway" field for a node and convert it to 0 in the case that it is a string (like "Direct")
  • Added a column sort for "Connection" that takes the function above and uses it to sort the values as appropriate.

Testing Done

Added tests to cover basic functionality of the generic table

Screenshots (if applicable)

Before:
image

After:
image

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All CI checks pass
  • Dependent changes have been merged

Additional Notes

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bkimmel bkimmel force-pushed the issue459/direct_nodes branch from 92b6f78 to c590ab2 Compare March 11, 2025 00:31
@bkimmel bkimmel marked this pull request as ready for review March 11, 2025 00:34
@danditomaso danditomaso self-requested a review March 11, 2025 01:56
@danditomaso danditomaso merged commit 3240ac5 into meshtastic:master Mar 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Node sorting by connection (hops away) puts "Direct" at the farthest away.
3 participants