Feature: Admin PKI fields #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danditomaso
reviewed
May 13, 2025
|
Some refactoring was made to get rid of double onChange calls, and checks added before allowing managed mode. Would appreciate some help with testing if possible. |
|
@philon- Sounds good, thanks for taking a second look at this. I'll throughly test it out this afternoon. |
|
@philon- Nice work on this! I am testing it out now and every seems to work correctly regarding adding/updating/removing public keys. Well done. LGTM |
This was referenced May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The remaining two admin key fields have been added and at least one valid PKI field is required when setting managed mode.
Related Issues
#315 - Add ability to add all 3 PKI admin keys
#355 - Warn users from selecting managed node
Changes Made
Testing Done
Limited testing with RAK device on 2.6.4.b89355f Beta, more testing needed.
Screenshots (if applicable)
Checklist
Additional Notes