Skip to content

libserialport: Add version 0.1.2-1. #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libserialport: Add version 0.1.2-1. #2143

wants to merge 1 commit into from

Conversation

antoniovazquezblanco
Copy link
Contributor

No description provided.

@antoniovazquezblanco antoniovazquezblanco marked this pull request as draft June 4, 2025 18:37
@antoniovazquezblanco antoniovazquezblanco force-pushed the libserialport branch 3 times, most recently from 5941b3a to 83aaa78 Compare June 4, 2025 19:02
bgilbert
bgilbert reviewed Jun 7, 2025
View reviewed changes
subprojects/packagefiles/libserialport/config.h Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be generated with configure_file(), not hardcoded in the repo. Not every define in the upstream config.h.in is actually used, but some are and we should perform the appropriate feature tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bgilbert for the pointers. Currently looking into this. Will try to update soon.

Thanks! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now compiling. Thanks for the pointers! :D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature checks are still missing, and they generally look as though they'd be straightforward to implement. I think it'd be better to match upstream's checks as much as possible (especially since upstream doesn't have functional tests) unless you have a good argument for why they aren't necessary.

@antoniovazquezblanco antoniovazquezblanco force-pushed the libserialport branch 7 times, most recently from 9515936 to fad548d Compare June 13, 2025 18:19
@antoniovazquezblanco antoniovazquezblanco marked this pull request as ready for review June 13, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgilbert bgilbert Awaiting requested review from bgilbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoniovazquezblanco @bgilbert