Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-10047: Convert /oauth2/ pages to React #940

Merged
merged 1 commit into from
Jun 4, 2019
Merged

MBS-10047: Convert /oauth2/ pages to React #940

merged 1 commit into from
Jun 4, 2019

Conversation

mwiencek
Copy link
Member

@mwiencek mwiencek commented Feb 23, 2019 •
edited by reosarevok
Loading

reosarevok
reosarevok reviewed Feb 23, 2019
View reviewed changes
root/oauth2/Oob.js Outdated Show resolved Hide resolved
@mwiencek mwiencek force-pushed the mbs-10047 branch 2 times, most recently from 3ee38e3 to d15ef32 Compare February 25, 2019 15:39
@mwiencek mwiencek force-pushed the mbs-10047 branch 2 times, most recently from 2ed535b to fe7e8fb Compare March 6, 2019 23:40
@mwiencek mwiencek force-pushed the mbs-10047 branch 2 times, most recently from 4bfeae5 to e3bf2b1 Compare June 3, 2019 15:59
@mwiencek
Copy link
Member Author

mwiencek commented Jun 3, 2019

@reosarevok @yvanzo ping! (I think this is the oldest PR not blocked by anything.)

@mwiencek mwiencek requested review from yvanzo and reosarevok June 3, 2019 16:02
@mwiencek mwiencek force-pushed the mbs-10047 branch 2 times, most recently from 9ca52f2 to 8de2d05 Compare June 3, 2019 16:20
reosarevok
reosarevok approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it seems to work. I'd prefer "No, thanks" to "No thanks", but given it's probably already translated, we probably shouldn't change it.

root/constants.js Show resolved Hide resolved
yvanzo
yvanzo approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, only minor coding style issues.

root/oauth2/OAuth2Error.js Outdated Show resolved Hide resolved
root/oauth2/OAuth2Authorize.js Outdated Show resolved Hide resolved
root/server/components.js Show resolved Hide resolved
root/account/applications/Index.js Outdated Show resolved Hide resolved
root/constants.js Show resolved Hide resolved
@mwiencek mwiencek merged commit 87f9975 into metabrainz:master Jun 4, 2019
@mwiencek mwiencek deleted the mbs-10047 branch June 4, 2019 16:50
anirudhjain75 pushed a commit to anirudhjain75/musicbrainz-server that referenced this pull request Jun 18, 2019
@mwiencek
MBS-10047: Convert /oauth2/ pages to React (metabrainz#940)
249a3c8
yvanzo added a commit that referenced this pull request Aug 8, 2019
@yvanzo
Merge branch 'beta' into production
1efa4b2 
* beta:
  Update pot files using current code and production database.
  Update translations from transifex.
  MBS-10139: Make the doc link open in a new tab (#1135)
  Update pot files using current code and production database.
  Fix sentence period position
  Update translations from transifex.
  Only show collaborative collections if available
  MBS-10246: Remove AttendanceLinks.js
  MBS-9428: List collaborative collections in the WS
  MBS-9428: Allow browsing by collaborative collection
  MBS-9428:  Show # of collaborators for collection
  MBS-9428: Let collaborator see collection on WS
  Move is_collection_collaborator to a Data method
  MBS-9428: Let collaborators see collection edits
  Rename forms to VerbNoun
  Do not run insert_many if array doesn't contain defined items
  Show the right number of collections on sidebar
  MBS-9381: Show private collections you have access to
  MBS-9428: Allow collaborators to remove entities from collection page
  MBS-9428: Remove collaborators on collection removal
  MBS-9428: Show collaborators on collection page
  MBS-9428: Show collaborative collections under user/collections
  MBS-9428: Let collaborators add/remove collection entities
  MBS-9428: Allow adding/removing collection collaborators
  Allow for uncontrolled select fields
  Remove unused template from stash
  Bump Flow to 0.102.0
  MBS-10233: Use React templates when canceling edit (#1105)
  MBS-10218: Fix page param (cover_art -> cover-art) (#1098)
  MBS-10139: Indicate why recording length can't be edited (#1037)
  Fix small issues in comments
  Eslint fixes: no-unused-vars
  Regex improvements
  Eslint fixes for guess case
  Bump Flow to 0.101.0
  Change loopParity to return an odd row for x=0
  MBS 10219: Add muziekweb.eu to otherDBs (#1099)
  MBS-10224: Show unique legal name list in overview
  MBS-8569: Hide ended legal names in overview
  MBS-10222: Show legal name aliases of legal name artist
  MBS-10217: Explain AC renaming in artist/edit_form (#1096)
  Remove unused file critiquebrainz.tt (#1095)
  Display frequency labels also on attribute tables
  MBS-8867: Don't uppercase "C'mon"
  MBS-10215: Make ISO number required for script form
  form_field_errors -> field_errors
  MBS-10210: Only allow accepted frequencies
  Output doc link with JSON WS error message
  Update web service documentation link to https
  Understand that "" is also a blank query
  MBS-10133: Clarify "empty query" bad request error
  MBS-10047: Convert /oauth2/ pages to React (#940)
  MBS-10212: Display artist name for SoundCloud w/ / (#1093)
  MBS-9512: Reject empty recording name edits (#566)
  Fix issues with custom track parser delimiters
  MBS-8915: Allow editors to choose delimiter in track parser
  Eslint fixes for places-map
  MBS-9914: Convert the area places tab to React
  MBS-10100: Don't require non-required fields for language
  MBS-9914: Convert the area users tab to React
  Make checkbox header on entity lists consistent
  Add merge checkboxes to AreaLabels for consistency
  MBS-9914: Convert the area releases tab to React
  Remove unneeded .js endings
  MBS-9914: Convert the area artists tab to React
  Split lyrics sites with cleanup from generic lyrics group
  MBS-10135: Support WikiaParoles as its own site rather than LyricWiki
  MBS-10131: Change LyricWiki domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvanzo yvanzo yvanzo approved these changes

@reosarevok reosarevok reosarevok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwiencek @reosarevok @yvanzo