Valgrind working on all node tests.

metacall · Jan 31, 2024 · 8b7a15b · 8b7a15b
1 parent 2833011
commit 8b7a15b
Show file tree

Hide file tree

Showing 2 changed files with 65 additions and 4 deletions.
diff --git a/source/tests/memcheck/valgrind-node.supp b/source/tests/memcheck/valgrind-node.supp
@@ -63,6 +63,32 @@
 	...
 	obj:*libnode*
 }
+{
+	<uv_poll_tcp_connect>
+	Memcheck:Leak
+	match-leak-kinds: reachable
+	fun:realloc
+	...
+	fun:uv__tcp_connect
+	fun:uv_tcp_connect
+	...
+	fun:uv__async_io
+	fun:uv__io_poll
+	...
+}
+{
+	<uv_poll_tcp_listen>
+	Memcheck:Leak
+	match-leak-kinds: reachable
+	fun:realloc
+	...
+	fun:uv__tcp_listen
+	fun:uv_listen
+	...
+	fun:uv__async_io
+	fun:uv__io_poll
+	...
+}
 {
 	<frame_ptr_ne>
 	Memcheck:Cond
@@ -218,12 +244,9 @@
 {
 	<node_loader_module_register>
 	Memcheck:Leak
-	match-leak-kinds: reachable
 	...
 	fun:napi_module_register
 	...
-	fun:loader_impl_initialize
-	...
 }
 {
 	<node_async_hooks_uninitialized_jump>
@@ -407,3 +430,40 @@
 	fun:_ZZN4node23WorkerThreadsTaskRunner20DelayedTaskScheduler5StartEvENUlPvE_4_FUNES2_
 	...
 }
+{
+	<node_builtin_compiler>
+	Memcheck:Leak
+	match-leak-kinds: possible
+	...
+	fun:ScheduleTimer
+	fun:_ZN2v88internal13MemoryReducer13ScheduleTimerEd
+	fun:_ZN2v88internal4Heap28NotifyOldGenerationExpansionENS0_15AllocationSpaceEPNS0_11MemoryChunkE
+	fun:_ZN2v88internal10PagedSpace9TryExpandEiNS0_16AllocationOriginE
+	fun:_ZN2v88internal10PagedSpace16RawRefillLabMainEiNS0_16AllocationOriginE
+	fun:_ZN2v88internal10PagedSpace13RefillLabMainEiNS0_16AllocationOriginE
+	fun:_ZN2v88internal19SpaceWithLinearArea20AllocateRawUnalignedEiNS0_16AllocationOriginE
+	fun:AllocateRawSlow
+	fun:AllocateRaw
+	fun:_ZN2v88internal13HeapAllocator11AllocateRawILNS0_14AllocationTypeE1EEENS0_16AllocationResultEiNS0_16AllocationOriginENS0_19AllocationAlignmentE
+	fun:AllocateRawWith<(v8::internal::HeapAllocator::AllocationRetryMode)1>
+	fun:_ZN2v88internal7Factory11AllocateRawEiNS0_14AllocationTypeENS0_19AllocationAlignmentE
+	fun:_ZN2v88internal11FactoryBaseINS0_7FactoryEE26AllocateRawWithImmortalMapEiNS0_14AllocationTypeENS0_3MapENS0_19AllocationAlignmentE
+	fun:_ZN2v88internal11FactoryBaseINS0_7FactoryEE21NewSharedFunctionInfoEv
+	fun:_ZN2v88internal11FactoryBaseINS0_7FactoryEE21NewSharedFunctionInfoENS0_11MaybeHandleINS0_6StringEEENS4_INS0_10HeapObjectEEENS0_7BuiltinENS0_12FunctionKindE
+	fun:_ZN2v88internal11FactoryBaseINS0_7FactoryEE31NewSharedFunctionInfoForLiteralEPNS0_15FunctionLiteralENS0_6HandleINS0_6ScriptEEEb
+	fun:_ZN2v88internal11interpreter17BytecodeGenerator25AllocateDeferredConstantsINS0_7IsolateEEEvPT_NS0_6HandleINS0_6ScriptEEE
+	fun:_ZN2v88internal11interpreter17BytecodeGenerator16FinalizeBytecodeINS0_7IsolateEEENS0_6HandleINS0_13BytecodeArrayEEEPT_NS5_INS0_6ScriptEEE
+	fun:_ZN2v88internal11interpreter25InterpreterCompilationJob17DoFinalizeJobImplINS0_7IsolateEEENS0_14CompilationJob6StatusENS0_6HandleINS0_18SharedFunctionInfoEEEPT_
+	fun:_ZN2v88internal11interpreter25InterpreterCompilationJob15FinalizeJobImplENS0_6HandleINS0_18SharedFunctionInfoEEEPNS0_7IsolateE
+	fun:_ZN2v88internal25UnoptimizedCompilationJob11FinalizeJobENS0_6HandleINS0_18SharedFunctionInfoEEEPNS0_7IsolateE
+	fun:_ZN2v88internal12_GLOBAL__N_139FinalizeSingleUnoptimizedCompilationJobINS0_7IsolateEEENS0_14CompilationJob6StatusEPNS0_25UnoptimizedCompilationJobENS0_6HandleINS0_18SharedFunctionInfoEEEPT_PSt6vectorINS0_34FinalizeUnoptimizedCompilationDataESaISE_EE
+	fun:_ZN2v88internal12_GLOBAL__N_155IterativelyExecuteAndFinalizeUnoptimizedCompilationJobsINS0_7IsolateEEEbPT_NS0_6HandleINS0_18SharedFunctionInfoEEENS6_INS0_6ScriptEEEPNS0_9ParseInfoEPNS0_19AccountingAllocatorEPNS0_15IsCompiledScopeEPSt6vectorINS0_34FinalizeUnoptimizedCompilationDataESaISI_EEPSH_INS0_27DeferredFinalizationJobDataESaISM_EE.constprop.0
+	fun:_ZN2v88internal12_GLOBAL__N_115CompileToplevelEPNS0_9ParseInfoENS0_6HandleINS0_6ScriptEEENS0_11MaybeHandleINS0_9ScopeInfoEEEPNS0_7IsolateEPNS0_15IsCompiledScopeE
+	fun:_ZN2v88internal8Compiler18GetWrappedFunctionENS0_6HandleINS0_6StringEEENS2_INS0_10FixedArrayEEENS2_INS0_7ContextEEERKNS0_13ScriptDetailsEPNS0_17AlignedCachedDataENS_14ScriptCompiler14CompileOptionsENSE_13NoCacheReasonE
+	fun:_ZN2v814ScriptCompiler23CompileFunctionInternalENS_5LocalINS_7ContextEEEPNS0_6SourceEmPNS1_INS_6StringEEEmPNS1_INS_6ObjectEEENS0_14CompileOptionsENS0_13NoCacheReasonEPNS1_INS_14ScriptOrModuleEEE
+	fun:_ZN2v814ScriptCompiler15CompileFunctionENS_5LocalINS_7ContextEEEPNS0_6SourceEmPNS1_INS_6StringEEEmPNS1_INS_6ObjectEEENS0_14CompileOptionsENS0_13NoCacheReasonE
+	fun:_ZN4node8builtins13BuiltinLoader24LookupAndCompileInternalEN2v85LocalINS2_7ContextEEEPKcPSt6vectorINS3_INS2_6StringEEESaISA_EEPNS1_6ResultE
+	fun:_ZN4node8builtins13BuiltinLoader16LookupAndCompileEN2v85LocalINS2_7ContextEEEPKcPNS_11EnvironmentE
+	fun:_ZN4node8builtins13BuiltinLoader15CompileFunctionERKN2v820FunctionCallbackInfoINS2_5ValueEEE
+	...
+}
diff --git a/source/tests/metacall_backtrace_plugin_test/CMakeLists.txt b/source/tests/metacall_backtrace_plugin_test/CMakeLists.txt
@@ -145,7 +145,8 @@ add_dependencies(${target}
 #
 
 set_property(TEST ${target}
-	PROPERTY LABELS ${target}
+	# Disable valgrind when testing backtracing for segfaults
+	PROPERTY LABELS ${target} MEMCHECK_IGNORE
 )
 
 include(TestEnvironmentVariables)