Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiarch #23

Closed
wants to merge 30 commits into from
Closed

Conversation

viferga
Copy link
Member

@viferga viferga commented Oct 28, 2024

I want to review this in detail because @Bcoderx6 you have changed a lot of things, first of all I want to add the patch to the csm for building 386 architecture. Then I want to review things.

I also have few questions, have you tested the new version of releases? Does it work with 0.17.0?

@viferga viferga marked this pull request as draft October 28, 2024 21:36
@viferga
Copy link
Member Author

viferga commented Oct 29, 2024

It seems to be stuck for some reason, maybe I should close this PR, can you return to the moment where it built for you on amd64 and failed for 386? @Bcoderx6

@Bcoderx6
Copy link
Contributor

Bcoderx6 commented Oct 31, 2024

@viferga, the Guix problem is now fixed, and the CI is running smoothly. Yes, GHR 0.17.0 is working fine; I tested it. I removed a line in the "Publish package to GitHub Releases" step because I believe the mv subdirectory is unnecessary. Additionally, I added strategy: matrix: arch: to fix the download artifact problem in the "Publish on GitHub" job. The amd64 architecture is fine, but we need to patch the SCM for the i386 architecture.

Link to the CI run

Link to Release

@viferga
Copy link
Member Author

viferga commented Nov 7, 2024

I am closing this one in favor of the new one; #24

I do not know why when I pushed my changes they did not appear in this PR.

@viferga viferga closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants