-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tests #27
fix: tests #27
Conversation
I cannot merge this at all because of the following reasons, this is the current state of the master branch in this repo: If you go to those CIs that have failed, you will see this:
The tests are basically failing because the rpath is not defined properly, not because of the metacall executable is not found as you told me in Discord. There is one more test failing than the current state of the master branch, and if we go to your CI tests to check the logs:
That issue is already solved in master. The current master has reached to find the executable already, the only problem remaining is to solve the rpath properly, which I am thinking to solve in the Maybe I am missing something but I do not get the point of this, you have submitted this twice and the problem you are trying to solve is already solved. The next step is to add this https://stackoverflow.com/questions/19209515/how-to-make-xcode-project-with-homebrew-libraries-portable/47897552#47897552 into brew-pkg and solve the rpath issues on the tgz tests. And also if we do TDD properly as I am trying to do, I should not merge something that breaks on the CI or breaks the tests if they are already working. |
No description provided.