Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Down the Respective Programming Language #159

Closed
wants to merge 2 commits into from
Closed

Write Down the Respective Programming Language #159

wants to merge 2 commits into from

Conversation

Subhraneel77
Copy link

Description

A Statement is Given where the User can write down the Programming they will work with thereby alerting the System Highlighter to changing it's design accordingly.

Fixes #(42)

Syntax highlighting for each supported language #42

Type of change

  • This change requires a documentation update
  • Documentation update

@pep8speaks
Copy link

pep8speaks commented Jan 18, 2022

Hello @Subhraneel77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 34:8: E225 missing whitespace around operator
Line 35:20: E231 missing whitespace after ','

Line 39:8: E225 missing whitespace around operator
Line 40:21: E231 missing whitespace after ','

Line 26:1: W293 blank line contains whitespace
Line 26:1: W391 blank line at end of file

Line 48:51: E262 inline comment should start with '# '
Line 48:80: E501 line too long (81 > 79 characters)

Comment last updated at 2022-01-19 13:43:59 UTC

@viferga
Copy link
Member

viferga commented Jan 24, 2022

Your code does not solve the syntax highlighting problem. You just added a input and print. Jupyter uses codemirror under the hood: https://codemirror.net/

The idea is to make the cells look different depending on the language. For example, if we detect we are using Node, then use javascript highlighting, same for python etc.

You have here an example which is a bit different but it can help you, it's basically using codemirror in jupyter through a plugin in order to select the themes. We want something like that but per language, the theme is not important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants