Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CONTRIBUTE.md #14

Closed
wants to merge 3 commits into from
Closed

Added CONTRIBUTE.md #14

wants to merge 3 commits into from

Conversation

vr-varad
Copy link
Contributor

No description provided.

@viferga viferga marked this pull request as draft March 13, 2024 17:35
@viferga
Copy link
Member

viferga commented Mar 13, 2024

@vr-varad We already discussed this. The CONTRIBUTE of this page cannot go in the landing page itself, because the it will be published in the landing page and people may think that contributing to metacall/core is the description of the contirbuting of landing page, which is wrong.

For this reason I opened this issue: #13

We must create an issue template for contributing which will be ignored from the landing page and it won't be published there. Otherwise it creates confusion for the contributors.

@viferga
Copy link
Member

viferga commented Mar 13, 2024

Something like this: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

Or like that, but it must be ignored from the CI so it never gets pushed into the landing page. And it must not be in the README.md for the same reason.

@viferga
Copy link
Member

viferga commented Mar 25, 2024

@vr-varad I ended up doing this: dbbcb1f 43dbdee

This should be enough. You can extend contributing.md if you want, it won't be published to the landing anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants