Skip to content

WIP SRUopener #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

WIP SRUopener #682

wants to merge 6 commits into from

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Mar 28, 2025 •
edited
Loading

This is a draft and WIP.
@TobiasNx you can use it for functional testing.

Resolves #510.

@dr0i dr0i requested a review from TobiasNx March 28, 2025 12:18
@dr0i dr0i changed the title WIP SRUopener (#510) WIP SRUopener Mar 28, 2025
@dr0i dr0i moved this to Review in Metafacture Mar 28, 2025
@TobiasNx
Copy link
Contributor

Nice seems to work. +1
The printed logs are a little bit esoteric:

, startRecord=1, maximumRecords=1000, istream.length=7865
urlToOpen=https://services.dnb.de/sru/zdb?query=dnb.isil%3DDE-Sol1&operation=searchRetrieve&recordSchema=MARC21plus-xml&version=1.1&maximumRecords=1000&startRecord=1001
, startRecord=1001, maximumRecords=1000, istream.length=7865
urlToOpen=https://services.dnb.de/sru/zdb?query=dnb.isil%3DDE-Sol1&operation=searchRetrieve&recordSchema=MARC21plus-xml&version=1.1&maximumRecords=1000&startRecord=2001
, startRecord=2001, maximumRecords=1000, istream.length=7865
urlToOpen=https://services.dnb.de/sru/zdb?query=dnb.isil%3DDE-Sol1&operation=searchRetrieve&recordSchema=MARC21plus-xml&version=1.1&maximumRecords=1000&startRecord=3001
, startRecord=3001, maximumRecords=1000, istream.length=7865
urlToOpen=https://services.dnb.de/sru/zdb?query=dnb.isil%3DDE-Sol1&operation=searchRetrieve&recordSchema=MARC21plus-xml&version=1.1&maximumRecords=1000&startRecord=4001
, startRecord=4001, maximumRecords=1000, istream.length=437

@TobiasNx TobiasNx mentioned this pull request Mar 31, 2025
Open
@TobiasNx
Copy link
Contributor

@dr0i is still in review?

@dr0i
Copy link
Member Author

dr0i commented Apr 10, 2025

As we found out in #510 this PR needs a complete redesign.

@dr0i dr0i force-pushed the 510-addSruOpener branch from ecd9c8c to c3f3ad6 Compare April 10, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasNx TobiasNx TobiasNx approved these changes

Assignees
No one assigned
Labels
Conform To Catmandu Enhancement Flux
Projects
Metafacture
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SRU opener / open-sru
2 participants
@dr0i @TobiasNx