Skip to content

Rename PG Example for flatten in flux #214 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Rename PG Example for flatten in flux #214 #218

merged 2 commits into from
May 26, 2025

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented May 23, 2025

https://metafacture.org/playground/?example=flatten always links to the fix function. So I adjusted the name of flatten to enable to link to the flux command.

If okay I also have to adjust https://github.com/metafacture/metafacture-documentation/blob/master/linksAndExamples.tsv

See #214.

@TobiasNx TobiasNx requested a review from dr0i May 23, 2025 12:49
@TobiasNx
Copy link
Contributor Author

Failing test is fixed in #217

TobiasNx added a commit to metafacture/metafacture-documentation that referenced this pull request May 23, 2025
Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break some links part of some more documentations somewehere. These should be at least addressed in PRs made in the respective repo, referencing this repo.

@dr0i dr0i removed their assignment May 23, 2025
@dr0i
Copy link
Member

dr0i commented May 23, 2025

hm, you already mention to update https://github.com/metafacture/metafacture-documentation/blob/master/linksAndExamples.tsv. Good. I am unsure, if this is ok then? Any other place?

@dr0i
Copy link
Member

dr0i commented May 26, 2025

I am unsure, if this is ok then? Any other place ?

Discussed offline with @TobiasNx that there is most probably no other reference.

@dr0i dr0i self-requested a review May 26, 2025 12:11
@dr0i dr0i merged commit 7943370 into main May 26, 2025
2 checks passed
@dr0i dr0i deleted the 214-flatten branch May 26, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants