Fix/allow double signer #1059
Merged
Fix/allow double signer #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelvanderwaal
requested review from
lorisleiva and
svc01-metaplex
and removed request for
a team
|
Workflow |
|
Workflow |
blockiosaurus
approved these changes
Mar 30, 2023
|
Thank you for this PR! We pulled this branch, compiled these contracts, ran locally and it passes 🥳 |
lorisleiva
approved these changes
Mar 31, 2023
|
@lorisleiva @blockiosaurus thanks folks for approving this PR, thanks @samuelvanderwaal for your amazing help! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1049. There is no reason to require only one signer and there's a use case where an Auction House might require RSO but still want the user to submit the transaction.