Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and test for collectionV2 #124

Merged
merged 6 commits into from
Jul 18, 2024
Merged

fix and test for collectionV2 #124

merged 6 commits into from
Jul 18, 2024

Conversation

tonyboylehub
Copy link
Contributor

@tonyboylehub tonyboylehub commented Jul 15, 2024 •
edited
Loading

  • Added CollectionV2 to Program
  • Modified resolver in JS client to default to collectionV2
  • Added/modified 3 tests to account for change in resolver

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-token-metadata-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 2:42pm

@tonyboylehub tonyboylehub changed the title fix and test for collectioV2 fix and test for collectionV2 Jul 15, 2024
@tonyboylehub tonyboylehub requested a review from danenbm July 18, 2024 00:05
danenbm
danenbm reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm, good tests too, but I think it just needs a lint fix on js

@tonyboylehub tonyboylehub merged commit 5c7672c into main Jul 18, 2024
11 checks passed
@tonyboylehub tonyboylehub deleted the tony/collectionV2-fix-and-test branch July 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danenbm danenbm danenbm left review comments

@blockiosaurus blockiosaurus blockiosaurus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyboylehub @danenbm @blockiosaurus