Skip to content

Commit

Permalink
fix: rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
Cluas committed Oct 21, 2024
1 parent 45fdef0 commit e4bf5c0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
7 changes: 0 additions & 7 deletions exporter/qrynexporter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@
- Default: `true`
- Description: Enables client-side processing of trace data. This can improve performance but may increase client-side resource usage.

<<<<<<< HEAD
- `dsn` (required): Clickhouse's dsn.
- `clustered_clickhouse` (required): true if clickhouse cluster is used
- `client_side_trace_processing`: use improved traces ingestion algorythm for clickhouse clusters.
Data ingestion is sess performant but more evenly distributed
=======
>>>>>>> e35202d (refactor: improve the code structure and documentation of qrynexporter.)

# Example:
## Simple Trace Data
Expand Down
3 changes: 0 additions & 3 deletions exporter/qrynexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ type Config struct {
configretry.BackOffConfig `mapstructure:"retry_on_failure"`
exporterhelper.QueueSettings `mapstructure:"sending_queue"`

<<<<<<< HEAD
=======
// ClientSideTraceProcessing is a boolean that indicates whether to process traces on the client side.
>>>>>>> e35202d (refactor: improve the code structure and documentation of qrynexporter.)
ClientSideTraceProcessing bool `mapstructure:"client_side_trace_processing"`

ClusteredClickhouse bool `mapstructure:"clustered_clickhouse"`
Expand Down
8 changes: 0 additions & 8 deletions exporter/qrynexporter/traces.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,19 +67,11 @@ func newTracesExporter(logger *zap.Logger, cfg *Config, set *exporter.Settings)
return nil, err
}
exp := &tracesExporter{
<<<<<<< HEAD
logger: logger,
meter: set.MeterProvider.Meter(typeStr),
db: db,
cluster: cfg.ClusteredClickhouse,
v2: cfg.ClusteredClickhouse && cfg.ClientSideTraceProcessing,
=======
logger: logger,
meter: set.MeterProvider.Meter(typeStr),
db: db,
cluster: cfg.ClusteredClickhouse,
clientSide: cfg.ClientSideTraceProcessing,
>>>>>>> e35202d (refactor: improve the code structure and documentation of qrynexporter.)
}
if err := initMetrics(exp.meter); err != nil {
exp.logger.Error(fmt.Sprintf("failed to init metrics: %s", err.Error()))
Expand Down

0 comments on commit e4bf5c0

Please sign in to comment.