Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datasources cancel button #479

Merged
merged 11 commits into from
Jul 19, 2024
Merged

Conversation

jacovinus
Copy link
Collaborator

@jacovinus jacovinus commented Jul 4, 2024

This changes the way datasources settings are stored

  • Previously the datasources fields were changed automatically without the option of a cancel button and aborting changes

For the new changes we will have a 'Cancel' button to set back all the fields to its initial values

  • adittionally will have a confirm on save dialog to confirm changes made on datasources settings
  • adds a cancel button to go back to previous settings
  • added Import JSON functionality

Refs: #455
Refs: #501

@jacovinus jacovinus added the enhancement New feature or request label Jul 4, 2024
@jacovinus jacovinus self-assigned this Jul 4, 2024
@jacovinus jacovinus merged commit b926e23 into main Jul 19, 2024
4 checks passed
@jacovinus jacovinus deleted the fix/datasources_cancel_button branch July 19, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant