Repeated solve #3
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
@aarmey I was talking to Andrew today about adding in a repeated solve for the projection matrix in case it was simply a convergence to the global minimum issue, so this code is adding in that change. From my initial runs it seems like the method is no longer failing (I capped it at 5 max repeated solves for now) which leads me to believe our objective function is not convex. We had a brief discussion about this during our last subgroup but if that is not an issue then this should be the finishing touch on the projection method. |
|
@Nathaniel-github I would prefer to not worry about it giving a local minimum for now. Keep in mind that it will give an improved result after fitting. Also, this fitting step will be run many times within Pf2. We can revisit convergence once you have a full method. |
|
@Nathaniel-github Let's keep this mind, but I will close the PR for now. |
No description provided.