Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw exception for empty interface #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't throw exception for empty interface #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/network_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,9 +347,11 @@ NetworkInterface::Info NetworkInterface::info() const {
#endif // _WIN32

// If we didn't even get the hw address or ip address, this went wrong
if (!collector.found_hw && !collector.found_ip) {
throw invalid_interface();
}
// Should this really return an exception?
// On Openwrt device with netem, an empty interface is created for sch_teql
// if (!collector.found_hw && !collector.found_ip) {
// throw invalid_interface();
// }

return info;
}
Expand Down