Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update read me #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update read me #3

wants to merge 1 commit into from

Conversation

simanga-dev
Copy link

update read me

@mgierada
Copy link
Owner

mgierada commented Dec 24, 2024 •
edited
Loading

Thanks @simanga-dev for the contribution!

As for now, the toggle function is not exposed publicly so one cannot define config the way you did this. This functionality is missing, thought it doesn't look like a complex nor time consuming thing to do. Feel free to update your PR.

On the other hand I don't see much value having toggle method. You can easily dismiss the floating terminal with q. Could you please elaborate more what is your use case? I might end up prioritizing the feature knowing that it makes sense to implement it.

@mgierada mgierada added the help wanted Extra attention is needed label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simanga-dev simanga-dev

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simanga-dev @mgierada