Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks to add elasticsearch as the task event history backend to flower.
Proposed Solution
Note this essentially still the original PR #821 (I don't recall why I closed it)
This is mainly 2 pieces:
Done so far (working)
indexing tasks into elasticsearch
Searching (moderate support for different fields), sorting on all fields. The sorting & pagination work but need more QA.
Dashboard able to pull from elasticsearch (at startup)
Questions
where will this logic live? flower subcommand? flower proper (w/ elasticsearch flag settings) @johnarnold
originally I had the indexer outside of flower. It's now in flower, but configured in a hack-off standalone mode, based currently just on
argv
. There are a few--elasticsearch
flags to control the behavior, just for draft/dev mode for now.I am using
kombu
'sLRUCache
to cache certainsearch_after
queries for the task history pagination. It is my way around the elasticsearch pagination restrictions, and keeps deep pagination requests super performant in my testing.can we improve the elasticsearch indexing process?