Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tag v2020.11.23.00 for fbthrift and folly #1

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Use tag v2020.11.23.00 for fbthrift and folly #1

merged 1 commit into from
Nov 29, 2020

Conversation

concatime
Copy link
Contributor

It’s generally a bad idea to use master for your submodules. Always use a tag/release.

Also, could you please use the "standard" format v${version} instead of release-${version} for your next tag/release?

Thank you!

@mhx mhx merged commit 067cebc into mhx:main Nov 29, 2020
@concatime concatime deleted the submodules-use-tags branch November 29, 2020 19:42
@gryffus gryffus mentioned this pull request Aug 13, 2022
@ghost ghost mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants