Skip to content

Commit

Permalink
hotfix: rateLimit property in endpoint routes is not required (#328)
Browse files Browse the repository at this point in the history
* hotfix: rate limit in routes not required

* chore: changelog

* fix: changeset

* version bump

---------

Co-authored-by: ThisIsDemetrio <Demetrio Marino>
Co-authored-by: Federico Maggi <[email protected]>
  • Loading branch information
ThisIsDemetrio and fredmaggiowski authored Nov 26, 2024
1 parent 89a7395 commit 1129bd6
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 13 deletions.
5 changes: 5 additions & 0 deletions .changeset/cuddly-paws-obey.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@mia-platform/console-types": patch
---

hotfix: `rateLimit` property in routes not required
6 changes: 6 additions & 0 deletions packages/console-types/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@

- 5316390: feat: supporting interpolation for service environment variable secret key"

## 0.24.7

### Patch Changes

- e489192: hotfix: `rateLimit` property in routes not required

## 0.24.6

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/console-types/src/types/endpoints.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ const routes = {
type: 'object',
properties: endpoint.route,
additionalProperties: false,
required: ['id', 'path', 'acl', 'backofficeAcl', 'public', 'secreted', 'showInDocumentation', 'verb', 'rateLimit'],
required: ['id', 'path', 'acl', 'backofficeAcl', 'public', 'secreted', 'showInDocumentation', 'verb'],
},
} as const

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2267,7 +2267,6 @@ Object {
"secreted",
"showInDocumentation",
"verb",
"rateLimit",
],
"type": "object",
},
Expand Down Expand Up @@ -2854,7 +2853,6 @@ Object {
"secreted",
"showInDocumentation",
"verb",
"rateLimit",
],
"type": "object",
},
Expand Down Expand Up @@ -3438,7 +3436,6 @@ Object {
"secreted",
"showInDocumentation",
"verb",
"rateLimit",
],
"type": "object",
},
Expand Down Expand Up @@ -4039,7 +4036,6 @@ Object {
"secreted",
"showInDocumentation",
"verb",
"rateLimit",
],
"type": "object",
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,7 @@ exports[`src/types/endpoints.test.ts TAP endpoints schema > must match snapshot
"public",
"secreted",
"showInDocumentation",
"verb",
"rateLimit"
"verb"
]
}
},
Expand Down Expand Up @@ -1046,8 +1045,7 @@ exports[`src/types/endpoints.test.ts TAP endpoints schema > must match snapshot
"public",
"secreted",
"showInDocumentation",
"verb",
"rateLimit"
"verb"
]
}
},
Expand Down Expand Up @@ -1634,8 +1632,7 @@ exports[`src/types/endpoints.test.ts TAP endpoints schema > must match snapshot
"public",
"secreted",
"showInDocumentation",
"verb",
"rateLimit"
"verb"
]
}
},
Expand Down Expand Up @@ -2221,8 +2218,7 @@ exports[`src/types/endpoints.test.ts TAP endpoints schema > must match snapshot
"public",
"secreted",
"showInDocumentation",
"verb",
"rateLimit"
"verb"
]
}
},
Expand Down

0 comments on commit 1129bd6

Please sign in to comment.