Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape Markdown bullets in morse conversion/deconversion output #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

posimagi
Copy link

@posimagi posimagi commented Jul 28, 2024

Description

render morse conversion output in fixed width, and escape Markdown bullets at the start of morse deconversion

Fixes #484

Type of change

  • Bug fix

How has this been tested?

Tested string manipulation in a local Python instance. I currently have no way to test the generation of Discord embeds.

Checklist

  • Issue exists for PR
  • Code reviewed by the author
  • Code documented (comments or other documentation)
  • Changes tested
  • All tests pass (see DEVELOPING.md, if it exists)
  • CHANGELOG.md updated if needed
  • Informative commit messages
  • Descriptive PR title

@posimagi posimagi changed the title escape Markdown bullets escape Markdown bullets in morse conversion/deconversion output Jul 28, 2024
exts/morse.py Outdated Show resolved Hide resolved
exts/morse.py Outdated Show resolved Hide resolved
@posimagi posimagi force-pushed the escape-morse-bullets branch from c7977c5 to 0fae3eb Compare July 28, 2024 20:51
@posimagi
Copy link
Author

updated PR

@classabbyamp
Copy link
Member

don't worry about the CI failure for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Morse code conversions/deconversions starting with characters that can be coerced into Markdown bullets do so
2 participants