Fix bug in giphy when decoding to json (#4)

micnncim · Oct 14, 2019 · 81f96dc · 81f96dc
1 parent ca4488d
commit 81f96dc
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/pkg/giphy/giphy.go b/pkg/giphy/giphy.go
@@ -14,15 +14,15 @@ const gifURLFormat = "https://media.giphy.com/media/%s/giphy.gif"
 const apiBaseURLFormat = "https://api.giphy.com/v1/%s"
 
 type Giphy struct {
-	Type   string `json:"type"`
-	ID     string `json:"id"`
-	URL    string `json:"url"`
-	Title  string `json:"title"`
-	GIFURL string `json:"gifurl"`
+	Type  string `json:"type"`
+	ID    string `json:"id"`
+	URL   string `json:"url"`
+	Title string `json:"title"`
 }
 
 func (g *Giphy) GIFURLInMarkdownStyle() string {
-	return fmt.Sprintf("![](%s)", g.GIFURL)
+	gifURL := fmt.Sprintf(gifURLFormat, g.ID)
+	return fmt.Sprintf("![](%s)", gifURL)
 }
 
 type Payload struct {
@@ -75,9 +75,5 @@ func (c *Client) Search(q string) ([]*Giphy, error) {
 		return nil, err
 	}
 
-	data := payload.Data
-	for _, g := range data {
-		g.GIFURL = fmt.Sprintf(gifURLFormat, g.ID)
-	}
-	return data, nil
+	return payload.Data, nil
 }