This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Accept uppercase LGTM as one of the default triggers #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I always forget the `lgtm` in the default trigger is lowercase. I know I can override the trigger but I'm thinking maybe you'll want to accept uppercase `LGTM` as one of the default triggers? Even this repository's description uses the uppercase variant in a few cases including the README picture so I think it might make sense? WDYT? BTW as far as I can tell this shouldn't already work because the regex case-insensitive flag in the default input string is missing and `parseTrigger` doesn't add it but if it already does work maybe the problem is just with our setup. I don't use Go so I just followed what I learnt on SO in terms of how to make a pattern case-insensitive.
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I always forget the
lgtmin the default trigger is lowercase. I know I can override the trigger but I'm thinking maybe you'll want to accept uppercaseLGTMas one of the default triggers? Even this repository's description uses the uppercase variant in a few cases including the README picture so I think it might make sense? WDYT?BTW as far as I can tell this shouldn't already work because the regex case-insensitive flag in the default input string is missing and
parseTriggerdoesn't add it but if it already does work maybe the problem is just with our setup. I don't use Go so I just followed what I learnt on SO in terms of how to make a pattern case-insensitive.