Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shopify] Sales Channels publishing for new products #27540

Merged
merged 25 commits into from
Dec 6, 2024

Conversation

tinestaric
Copy link
Contributor

@tinestaric tinestaric commented Oct 25, 2024

This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko
Fixes #26819

Sales Channels publishing for new products

This PR contains new functionality where user can choose Sales Channels which will new products be published to on creation from BC.

Solution contains new page and table - Shopify Sales Channels available from Shopify Shop. On page user can import sales channels available for shop and choose to which new products should be published to. If user does not choose any of the channels, then channel "Online Shop" is being used by default.

In case user did not import Sales Channels before running create product sales channels are pulled from Shopify on before publishing and default channel is used.

Pulled sales channels are updated in BC - in case the channel was removed in Shopify its removed from list in BC.

Modified/new objects

  • New GQL query codeunit was created to import the Sales Channels.
  • New GQL Query Enum Value
  • New codeunit Shpfy Sales Channel API to handle sales channels import
  • Removed detracted published = true from Shpfy Product API, added procedures to handle new way of publishing new products to sales channels
  • Sales Channels page and table
  • New action on Shopify Shop Card page - Sales Channels

Fixes AB#556526, AB#550319

@tinestaric tinestaric requested a review from a team as a code owner October 25, 2024 08:52
@tinestaric tinestaric requested a review from blrobl October 25, 2024 08:52
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Oct 25, 2024
@JesperSchulz JesperSchulz added the linked Issue is linked to a Azure Boards work item label Nov 1, 2024
@onbuyuka
Copy link
Contributor

onbuyuka commented Nov 5, 2024

@petemchlk left some comments, otherwise looks good

@petemchlk
Copy link
Contributor

@onbuyuka applied your suggestions :)

onbuyuka
onbuyuka previously approved these changes Nov 6, 2024
@onbuyuka onbuyuka enabled auto-merge (squash) November 11, 2024 11:52
@JesperSchulz JesperSchulz self-assigned this Nov 21, 2024
@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Nov 21, 2024
onbuyuka
onbuyuka previously approved these changes Nov 21, 2024
@JesperSchulz JesperSchulz removed their assignment Nov 27, 2024
JesperSchulz
JesperSchulz previously approved these changes Dec 3, 2024
Copy link
Contributor

@JesperSchulz JesperSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating IDs.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Issue #26819 is not valid. Please make sure you link an issue that exists, is open and is approved.

@JesperSchulz
Copy link
Contributor

This PR was processed internally. We had to make sure adjustments to the tests to make them pass.
@onbuyuka, do you want to apply your changes, or should we just close this PR?

@aholstrup1 aholstrup1 disabled auto-merge December 6, 2024 09:55
@aholstrup1 aholstrup1 merged commit 07ec75f into microsoft:main Dec 6, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] Shopify Contributions
6 participants