Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salesperson API #27664

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Salesperson API #27664

wants to merge 5 commits into from

Conversation

miljance
Copy link
Contributor

@miljance miljance commented Nov 21, 2024

Summary

A new API page for Salespeople/Purchasers
I created the tests in a similar manner that I found suitable for Locations, but I did not manage to run the test. Thus, looking forward to the feedback if tests do pass in Microsoft Pipelines or how to test those calls in a container. Currently I do not have a clue how to do it.

Work Item(s)

Fixes #26806

Fixes AB#541735

@miljance miljance requested a review from a team as a code owner November 21, 2024 12:39
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Nov 21, 2024
@onbuyuka
Copy link
Contributor

onbuyuka commented Nov 21, 2024

For tests, you need to use Isolation Disabled test runner codeunit to run them in a container

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Nov 21, 2024
Copy link
Contributor

@pri-kise pri-kise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't how useful this API will be with this limited set of fields.

At least the following further fields should be added in my opinion:

  • "Phone No."
  • "E-Mail 2"
  • "Job Title"
  • "Commission %"
  • "Privacy Blocked"
  • Blocked

and maybe also "Coupled to Dataverse".

@miljance
Copy link
Contributor Author

For tests, you need to use Isolation Disabled test runner codeunit to run them in a container

Feedback integrated into the change.
I have used the "Test Runner - Isol. Disabled" codeunit as TestRunner but the problem I have is that I do not know how to run the automated tests that are counting on the fact that the Webservices should work in a container.

image

@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Nov 27, 2024
onbuyuka
onbuyuka previously approved these changes Nov 27, 2024
JesperSchulz
JesperSchulz previously approved these changes Nov 27, 2024
@JesperSchulz JesperSchulz dismissed stale reviews from onbuyuka and themself via 4abaa75 November 27, 2024 14:35
JesperSchulz
JesperSchulz previously approved these changes Nov 27, 2024
onbuyuka
onbuyuka previously approved these changes Nov 27, 2024
Should make the PR pass CI.
@JesperSchulz JesperSchulz dismissed stale reviews from onbuyuka and themself via 99ccfa2 November 28, 2024 14:51
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Nov 29, 2024

This one is merged internally. Small change was forgotten. Will update this PR and give it another run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BC Idea]: API Page for Sales Persons
4 participants