Added M365 connections to shared #2090
Conversation
| function Show-EXOConnection { | ||
| param ( | ||
| [Parameter(Mandatory = $true)] | ||
| [Microsoft.Exchange.Management.ExoPowershellSnapin.ConnectionInformation]$Connection |
There was a problem hiding this comment.
Does this correctly work when you have multiple sessions used with $AllowMultipleSessions
There was a problem hiding this comment.
I think so, you are sending by parameter the session that you created, just one, and that is the one that we are showing.
If you create a second one or a third one, is going to have a new call to the function that shows that information.
I think I test it when I created, but I will test it and paste some screenshots.
There was a problem hiding this comment.
Okay, $newConnection should only have 1 object in the array by the time we get here, so it should work as expected.
| if (-not $DoNotShowConnectionDetails) { | ||
| Show-EXOConnection -Connection $newConnection | ||
| } | ||
| return $newConnection |
There was a problem hiding this comment.
Why are we returning a connection here? Trying to understand this.
There was a problem hiding this comment.
Big reason why is trying to understand this section of code:
if ($null -eq $connections -or $AllowMultipleSessions) {
if ($connections.ModulePrefix -contains $Prefix) {
Write-Host "You already have a session with the prefix $Prefix" -ForegroundColor Red
return $null
} else {
There was a problem hiding this comment.
I want to return the connection because you could use different connections and you can control which one is under your responsibility, which one you created and which one is not your connection.
On that part of the code, I want to create a connection only if you do not have a connection and you do not use allow multiplesessions.
In case that you use allowmultiplesession, we will verify that we do not have a duplicated prefix.
It could be useful in future in case that we want to close a created connection or the one that you are going to use.
For example, in MDO we get information from EXO connection and compare with Graph connection to confirm that we are connected to the same tenant.
|
We should also look into adding pester testing here as well. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| function Show-EXOConnection { | ||
| param ( | ||
| [Parameter(Mandatory = $true)] | ||
| [Microsoft.Exchange.Management.ExoPowershellSnapin.ConnectionInformation]$Connection |
There was a problem hiding this comment.
Okay, $newConnection should only have 1 object in the array by the time we get here, so it should work as expected.
Shared/M365/GraphConnection.ps1
Outdated
| [Parameter(Mandatory = $false)] | ||
| [switch]$DoNotShowConnectionDetails, | ||
| [Parameter(Mandatory = $false)] | ||
| [System.Version]$MinModuleVersion = 2.0.0.0 |
There was a problem hiding this comment.
Let's add a script validation here for the min version supported.
Let's also add some version information to get the module that we are currently using, just in case things change with Graph.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Issue:
Added two functions to Shared in case any script needs a connection to M365.
One function for Exchange Online another function for AzureAD
Reason:
Unify the way we connect to M365.
Fix:
Both functions will do the following:
Important: we do not disconnect at anytime we just verify if we have an active session