feat(eslint-config): Update constructor access modifier eslint rule to require explicit modifiers #13134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Josmithr
changed the title
github-actions
bot
added
area: dds
Josmithr
changed the title
alexvy86
reviewed
Dec 1, 2022
|
Waiting on ongoing discussion about major version changes in this and other individually published packages. Update: PR pre-emptively major-bumping the eslint config for this and other breaking changes: #13218 Update 2: Above PR merged. This is ready to go. |
Josmithr
changed the title
ChumpChief
approved these changes
Dec 2, 2022
CraigMacomber
approved these changes
Dec 3, 2022
CraigMacomber
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates rule to match discussion outcome in this discussion.
Rule documentation: https://typescript-eslint.io/rules/explicit-member-accessibility/
Also fixes violations in packages using the
strictconfigBreaking Change
Note that this is a breaking change with respect to the above rule. We are changing error-level enforcement of the policy to the opposite rule, so code changes will be required. This PR pre-fixes the violations existing at this point in time, but any changes between now and when the new package is published and adopted will need to be fixed.