Fix/#3885 aad conditional access policy #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deApplications are not enforced microsoft#3885
…://github.com/swisscom/Microsoft365DSC into fix/microsoft#3885-AADConditionalAccessPolicy
|
For the other attribute (Include Application) "None" is already present if no Application are defined. That ensure the right handling of the attribute. |
ykuijs
requested changes
Nov 29, 2023
...soft365DSC/DSCResources/MSFT_AADConditionalAccessPolicy/MSFT_AADConditionalAccessPolicy.psm1
Show resolved
Hide resolved
|
Can we please fix the merge conflicts and I will review after. Thanks |
|
@sandrola Could you please update with Dev and make sure the items in the changelog are placed under the Unreleased section? After that we can merge the PR |
|
Can you please tell me what is missing to this contribution? Is open since long time and would be great to have this integrated. Thanks! |
NikCharlebois
approved these changes
Jan 8, 2024
|
PR approved, please fix the merge conflict and I will merge. |
NikCharlebois
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Implement Fix #3885. Manage Exclude Application.
This Pull Request (PR) fixes the following issues