Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] IntuneDeviceManagementComplianceManagementPartner #5333

Open
wants to merge 34 commits into
base: Dev
Choose a base branch
from

Conversation

salbeck-sit
Copy link
Contributor

Pull Request (PR) description

Initial release (take two).

CimInstances from DRG-generated resource has been 'flattened' to one level and property GroupDisplayName has been added to ensure cross-tenant capability.
I have omitted property 'lastHeartbeatDateTime' although it appears possible to modify it.

Not too sure about property 'CollectionId' in the ...AssignmentTarget CimInstance. Advice is welcome.

This Pull Request (PR) fixes the following issues

@salbeck-sit
Copy link
Contributor Author

Posted an issue with regards to ConvertTo-IntunePolicyASsignment silently dropping assignments for groups that can't be read - this includes unit-tests failing in spite of required mocks. The easy workaround was to omit datatype *GroupAssignmentTarget from unit-tests. However in cross-tenant scenarios it's not implausible to reference a group that might not exist and in such a situation the resource should emit some sort of warning

@salbeck-sit
Copy link
Contributor Author

updated resource to write event if a group is unknown - when getting assignments that refer to an unkown group, a warning is written, when setting assignments that refer to an unknown group, an error is written. I'm still undecided if that should cause an exception to avoid thinking that a configuration was updated if it really wasn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant