Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module iOS VPN #5386

Open
wants to merge 1 commit into
base: Dev
Choose a base branch
from

Conversation

dannyKBjj
Copy link
Contributor

Work in progress

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Work in progress
@dannyKBjj
Copy link
Contributor Author

@microsoft-github-policy-service agree

@ykuijs
Copy link
Member

ykuijs commented Nov 13, 2024

Hi @dannyKBjj, thanks for creating this resource and contributing it to the project. Unfortunately there is still some stuff missing. All of our resources require unit tests (which are also completing successfully) and example files, for example:

Also we need an entry of this new resource in the changelog: https://github.com/microsoft/Microsoft365DSC/blob/Dev/CHANGELOG.md

Could you please add these items to the PR?

@dannyKBjj
Copy link
Contributor Author

Ok, no problem. Will get it done

@ykuijs
Copy link
Member

ykuijs commented Nov 22, 2024

@dannyKBjj Can you please make sure this PR is updated as well, just like the other ones? Then we can review and merge it.

@dannyKBjj
Copy link
Contributor Author

Hi yes, sorry. I'm working on a number of modules that we require and that one's been bumped down my priority list a bit! I'll get it up to scratch like the others early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants