-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default Ensure value if not present #5449
Add default Ensure value if not present #5449
Conversation
@Borgquite Do you have the time to test it with your usecase? |
5f54f4f
to
a9f7797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great solution! I will merge this PR when @Borgquite confirms this solution solves the issue |
Will do! Give me a day or so. |
Our next release is Wednesday next week, so a day is no problem 😉 |
@Borgquite Any updates on the testing? Wednesday is just around the corner, would be awesome if we could integrate that. |
@FabienTschanz Hey - sorry, stuff got in the way (although I'm still happy to do this). On paper it looks fine so if you want to integrate I can get back to you if it's still a problem. I'll see if I can get round to it this afternoon (but keep getting asked to come into meetings... sigh) |
Pull Request (PR) description
This PR adds the default
Ensure
property valuePresent
if it is not specified in the desired values and the resource is not a single instance element.This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).