Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default Ensure value if not present #5449

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

This PR adds the default Ensure property value Present if it is not specified in the desired values and the resource is not a single instance element.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@FabienTschanz
Copy link
Contributor Author

@Borgquite Do you have the time to test it with your usecase?

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs
Copy link
Member

ykuijs commented Nov 22, 2024

Great solution! I will merge this PR when @Borgquite confirms this solution solves the issue

@Borgquite
Copy link
Contributor

Will do! Give me a day or so.

@ykuijs
Copy link
Member

ykuijs commented Nov 22, 2024

Our next release is Wednesday next week, so a day is no problem 😉

@FabienTschanz
Copy link
Contributor Author

@Borgquite Any updates on the testing? Wednesday is just around the corner, would be awesome if we could integrate that.

@Borgquite
Copy link
Contributor

@FabienTschanz Hey - sorry, stuff got in the way (although I'm still happy to do this).

On paper it looks fine so if you want to integrate I can get back to you if it's still a problem. I'll see if I can get round to it this afternoon (but keep getting asked to come into meetings... sigh)

@NikCharlebois NikCharlebois merged commit 2adbaf6 into microsoft:Dev Nov 27, 2024
2 checks passed
@FabienTschanz FabienTschanz deleted the fix/default-ensure-value branch November 27, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants