Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limited Microsoft Graph results on Get #5456

Open
wants to merge 3 commits into
base: Dev
Choose a base branch
from

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

This PR fixes the issue where filtering by display name in Microsoft Graph did not return the policy when there are more than 25 policies of the same type. Filtering seems to occur after fetching the first 25 policies from the database, leading to no policy found, even though it did exist.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs
Copy link
Member

ykuijs commented Nov 26, 2024

Just a quick check: I assume you have validated that all these cmdlets really have an All parameter, correct?

@FabienTschanz
Copy link
Contributor Author

Just a quick check: I assume you have validated that all these cmdlets really have an All parameter, correct?

Yes, they all do 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants