Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FilePreview] Add support for descript.ion files #35599

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[FilePreview] Add support for descript.ion files #35599

merged 2 commits into from
Nov 28, 2024

Conversation

octastylos-pseudodipteros
Copy link
Contributor

Summary of the Pull Request

Adds file preview support for descript.ion files

PR Checklist

  • Closes: Support .ion-files in Peek #35515
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: No need
  • New binaries: None
  • Documentation updated: No need

Detailed Description of the Pull Request / Additional comments

Adds .ion to txtExt in monaco_languages.json

Validation Steps Performed

Manually tested previewing descript.ion file

@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Nov 13, 2024
jaimecbernardo
jaimecbernardo approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo added Good to Merge and removed Needs-Review This Pull Request awaits the review of a maintainer. labels Nov 28, 2024
@jaimecbernardo jaimecbernardo merged commit 2830483 into microsoft:main Nov 28, 2024
11 checks passed
@octastylos-pseudodipteros octastylos-pseudodipteros deleted the filepreview-descript.ion branch November 29, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
Good to Merge
Projects
5. Needs Attention
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@octastylos-pseudodipteros @jaimecbernardo @crutkas @htcfreek