Color picker wpf #37149
Open
Color picker wpf #37149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-o-Way
suggested changes
Jan 31, 2025
| <StackPanel | ||
| HorizontalAlignment="Center" | ||
| VerticalAlignment="Center" | ||
| AutomationProperties.LiveSetting="Assertive" | ||
| AutomationProperties.Name="{x:Static p:Resources.Copied_to_clipboard}" | ||
| Orientation="Horizontal"> | ||
| <ui:SymbolIcon | ||
| <TextBlock | ||
| FontFamily="Segoe Fluent Icons, Segoe MDL2 Assets" |
There was a problem hiding this comment.
Tip: never hardcode values like this. This is super sensitive to typos and other reasons for failure. Use a FontIcon instead :)
There was a problem hiding this comment.
There is no FontIcon in .net WPF.
| x:Name="OKButton" | ||
| Grid.Row="9" | ||
| Grid.ColumnSpan="4" | ||
| Margin="0,32,0,0" | ||
| HorizontalAlignment="Stretch" | ||
| Appearance="Primary" | ||
| Background="{DynamicResource {x:Static SystemColors.AccentColorBrushKey}}" |
There was a problem hiding this comment.
Is it possible to use {StaticResource} with a value from WinUI Gallery?
There was a problem hiding this comment.
We don't use WinUI but .net WPF.
src/modules/colorPicker/ColorPickerUI/Controls/ColorPickerControl.xaml
Outdated
Show resolved
Hide resolved
src/modules/colorPicker/ColorPickerUI/Controls/ColorFormatControl.xaml
Outdated
Show resolved
Hide resolved
|
First image on the left shows a button with black text on a green background. This is not good accessibility. Let's see how to fix that. (my general advice: stick with the basics) |
Jay-o-Way
reviewed
Jan 31, 2025
src/modules/colorPicker/ColorPickerUI/Views/ColorEditorView.xaml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Use .net WPF instead of WPFUI.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Comparison Windows 11. Left side new one, right side old one.
Light
Dark
Aquatic
Desert
Dusk
Night Sky
Validation Steps Performed
Test on W11 and W10, dark and light and all HC themes.