Automatic semicolon insertion for class modifiers #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes public, private, protected, abstract async and declare already work this way, but it looks like they didn't block the completion list, so I added them to the list too.
|
Hi @sandersn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Looks like tslint updated and broke some fourslash harness code. Wesley is fixing it. |
|
👍 |
1 similar comment
|
👍 |
sandersn
added a commit
that referenced
this pull request
Oct 5, 2015
Automatic semicolon insertion for class modifiers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes
public,private,protected, abstractasyncanddeclarealready do ASI, but it lookslike they didn't block the completion list at end of line, so I added
them to the list of identifiers that do that too.
Fixes #4611