-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the behavior of the method that loads llm_config and add new tests #3321
Open
umermansoor
wants to merge
3
commits into
0.2
Choose a base branch
from
llm_config_enhancements
base: 0.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an error on macOS build. A URL on Huggingface is timing out (working fine locally). I can take a look at it later tonight |
Are you willing to update the PR to ensure all tests pass? |
This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main. |
rysweet
added
the
awaiting-op-response
Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster
label
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0.2
Issues which are related to the pre 0.4 codebase
awaiting-op-response
Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current _validate_llm_config method contains redundancy and lacks comprehensive issue checks (for example, I was passing a string for tags and it didn't complain and required 30 minutes to debugging to figure out what the issue was). This improved version addresses these problems and includes 2 news tests.
Previous PR. Re-opening from upstream per Sonichi's comment.
Related issue number
Checks