-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileSurfer in AgentChat #4360
FileSurfer in AgentChat #4360
Conversation
python/packages/autogen-ext/src/autogen_ext/agents/file_surfer/_file_surfer.py
Show resolved
Hide resolved
The file surfer and the web surfer do tool calling very differently from AssistantAgent, mainly because they either have tool calls that use state or attributes of the agent itself. Though I am not certain they cant fit in the AssistantAgent template. If they can't fit, maybe we define another template for this type of agent (I could also see it being applied for the video agent and so). |
Let's make sure to add some unit tests per Eric's directions #4468 using the replay client |
We should discuss this. This is a straight port of MagenticOne, which is perhaps the primary reason for the direct tool calling, but I'm also concerned that most of my use of tool calling it to change agent state, and this seems not to be the intention of tool calling in AssistantAgent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gagb , For Web and File the agents are called Surfers, but for Video it is called VideoSurferAgent. Should we rename?
Perhaps! With or without the "Agent" suffix? |
* Added an implementation of FileSurfer to AgentChat
No description provided.