Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSurfer in AgentChat #4360

Merged
merged 17 commits into from
Dec 3, 2024
Merged

FileSurfer in AgentChat #4360

merged 17 commits into from
Dec 3, 2024

Conversation

afourney
Copy link
Member

No description provided.

@husseinmozannar
Copy link
Contributor

The file surfer and the web surfer do tool calling very differently from AssistantAgent, mainly because they either have tool calls that use state or attributes of the agent itself. Though I am not certain they cant fit in the AssistantAgent template. If they can't fit, maybe we define another template for this type of agent (I could also see it being applied for the video agent and so).

@husseinmozannar
Copy link
Contributor

Let's make sure to add some unit tests per Eric's directions #4468 using the replay client

@afourney afourney changed the title Initial commit of FileSurfer in AgentChat/ext. WIP FileSurfer in AgentChat Dec 2, 2024
@afourney afourney marked this pull request as ready for review December 2, 2024 21:55
@afourney
Copy link
Member Author

afourney commented Dec 3, 2024

The file surfer and the web surfer do tool calling very differently from AssistantAgent, mainly because they either have tool calls that use state or attributes of the agent itself. Though I am not certain they cant fit in the AssistantAgent template. If they can't fit, maybe we define another template for this type of agent (I could also see it being applied for the video agent and so).

We should discuss this. This is a straight port of MagenticOne, which is perhaps the primary reason for the direct tool calling, but I'm also concerned that most of my use of tool calling it to change agent state, and this seems not to be the intention of tool calling in AssistantAgent.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gagb , For Web and File the agents are called Surfers, but for Video it is called VideoSurferAgent. Should we rename?

@afourney
Copy link
Member Author

afourney commented Dec 3, 2024

@gagb , For Web and File the agents are called Surfers, but for Video it is called VideoSurferAgent. Should we rename?

Perhaps! With or without the "Agent" suffix?

@afourney afourney merged commit 5235bbc into main Dec 3, 2024
43 checks passed
@afourney afourney deleted the filesurfer branch December 3, 2024 20:14
rysweet pushed a commit that referenced this pull request Dec 10, 2024
* Added an implementation of FileSurfer to AgentChat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants