RPC over events #4414
Draft
RPC over events #4414
+339
−774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
commented
Nov 27, 2024
| # TODO add "-" to topic and agent type allowed characters in spec | ||
| closure_agent_type = f"rpc_receiver_{recipient.type}_{rpc_request_id}" | ||
|
|
||
| future: asyncio.Future[Any] = asyncio.Future() |
There was a problem hiding this comment.
todo save future to self
ekzhu
reviewed
Nov 27, 2024
python/packages/autogen-core/test.py
Outdated
ekzhu
reviewed
Nov 28, 2024
| type=closure_agent_type, | ||
| closure=set_result, | ||
| forward_unbound_rpc_responses_to_handler=True, | ||
| ) |
There was a problem hiding this comment.
I can't get over it. I think this particular ClosureAgent should be transient and removes itself quickly once this function scope is cleared.
There was a problem hiding this comment.
100% agree, it should be removed immediately. We just need to implement agent removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.