Test and Deprecate Publish HTML Report #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2023 02:30
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
|
Please remove all extra lines and spaces |
added 6 commits
December 8, 2023 12:35
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
added 12 commits
December 14, 2023 13:41
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
…t testing Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
…-coveragepublisher into users/shrchandra/CleanupforPublishHTMLReport
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
Signed-off-by: Shriti Chandra (from Dev Box) <[email protected]>
vinayakmsft
approved these changes
Jan 8, 2024
| @@ -31,7 +34,7 @@ public static void Main(string[] args) | |||
| ProcessCoverage(config, _cancellationTokenSource.Token); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Nit: Please remove extra line
|
|
||
|
|
||
| // Feature Flag for testing and deprecating PublishHTMLReport | ||
| if (!IsPublishHTMLReportDeprecationEnabled && config.GenerateHTMLReport) |
There was a problem hiding this comment.
The default state of FF should be off. When we turn it on , then only it should go inside this for loop. So you can remove the "!" mark for the FF name
| @@ -57,7 +57,7 @@ private static void ProcessCoverage(PublisherConfiguration config, CancellationT | |||
| var publishTimedout = processor.ParseAndPublishCoverage(config, cancellationToken, new Parser(config, context.TelemetryDataCollector)) | |||
| .Wait(config.TimeoutInSeconds * 1000, cancellationToken); | |||
|
|
|||
| if(publishTimedout) | |||
| if (publishTimedout) | |||
There was a problem hiding this comment.
Please remove extra space
| @@ -66,7 +66,7 @@ private static void ProcessCoverage(PublisherConfiguration config, CancellationT | |||
| publishSuccess = true; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
please remove extra line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are behind a Feature Flag.
Local testing
Taking a .xml file as input
With the FF set to OFF -
The HTML report is being generated and uploaded in the artifacts -
With the FF set to ON :
The HTML report is not being generated and consequently, it is not being published to artifacts