Generating Html only for Native Coverage #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description- Earlier we were lopping through all the input coverage files and calling the PublishHTMLReport(config.ReportDirectory, token) method for each of the valid native coverage file (.xml/.locv/.gcov) etc. This causes issue as it will generate a Report Directory for every file which is not required. Instead, we can improve this by just having an initial check condition that will check if all the inputs files are valid and does not contain the files like (.coverage/.cjson/covx/covb) and then call the PublishHtmlReport method only once for those input files thus generating 1 Report Directory. This change will improve the overall time of the PCCRV2 task and also would avoid unnecessary generating of the Report Directory for files.
With this change the performance of the PCCRV2 task improves. The code coverage data remains the same and no changes are impacted on those lines.
Testing :
Risk assessment:
Low