Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Configuration] Update App Configuration tasks description #20682

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MaryanneNjeri
Copy link
Contributor

Task name: App Configuration Tasks [App Configuration Import task, App Configuration Export task]

Description: Update tasks description and help url

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@MaryanneNjeri MaryanneNjeri requested a review from a team November 21, 2024 09:47
@ChristineWanjau
Copy link

We should also update the user-agent name -

const userAgent: string = `AzurePipelines.AzureAppConfiguration.Push/${taskVersion}`;

@ChristineWanjau
Copy link

We should update the third party notices text

This Azure DevOps extension (AzureAppConfigurationPush) is based on or incorporates material from the projects listed below (Third Party IP). The original copyright notice and the license under which Microsoft received such Third Party IP, are set forth below. Such licenses and notices are provided for informational purposes only. Microsoft licenses the Third Party IP to you under the licensing terms for the Azure DevOps extension. Microsoft reserves all other rights not expressly granted under this agreement, whether by implication, estoppel or otherwise.

"helpMarkDown": "Email [email protected] for questions.",
"category": "Utility",
"author": "Microsoft Corporation",
"version": {
"Major": 10,
"Minor": 247,
"Minor": 249,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, how do we decide the minor version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor version is based on the current sprint version please see-> https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/taskversionbumping.md

@@ -283,7 +283,7 @@
"InvalidTagsWithSample": "Invalid format for parameter 'Tags'. Sample 'Tags': {\"name1\": \"value1\", \"name2\":, \"value2\"}.",
"InvalidAppConfigurationEndpoint": "Invalid App Configuration endpoint %s. Please provide a valid App Configuration endpoint.",
"InvalidTypeInTags": "Invalid type in parameter 'Tags'. Only strings supported",
"AzureAppConfigurationPushTaskStartingUp": "Azure App Configuration Push Task is starting up...",
"AzureAppConfigurationPushTaskStartingUp": "Azure App Configuration Import Task is starting up...",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string name should be "AzureAppConfigurationImportTaskStartingUp"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this has been updated, thanks

@MaryanneNjeri
Copy link
Contributor Author

We should also update the user-agent name -

const userAgent: string = `AzurePipelines.AzureAppConfiguration.Push/${taskVersion}`;

@ChristineWanjau nice catch this has been updated, thanks

@MaryanneNjeri
Copy link
Contributor Author

We should update the third party notices text

This Azure DevOps extension (AzureAppConfigurationPush) is based on or incorporates material from the projects listed below (Third Party IP). The original copyright notice and the license under which Microsoft received such Third Party IP, are set forth below. Such licenses and notices are provided for informational purposes only. Microsoft licenses the Third Party IP to you under the licensing terms for the Azure DevOps extension. Microsoft reserves all other rights not expressly granted under this agreement, whether by implication, estoppel or otherwise.

@ChristineWanjau thanks for catching this has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants