Improve tests

microsoft · Nov 19, 2024 · 315ba25 · 315ba25
1 parent 9baedae
commit 315ba25
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 17 deletions.
diff --git a/src/script/acquisition-sdk.ts b/src/script/acquisition-sdk.ts
@@ -94,6 +94,7 @@ export class AcquisitionManager {
     public queryUpdateWithCurrentPackage(currentPackage: Package, callback?: Callback<RemotePackage | NativeUpdateNotification>): void {
         if (AcquisitionManager._apiCallsDisabled) {
             console.log(`[CodePush] Api calls are disabled, skipping queryUpdateWithCurrentPackage`);
+            callback(/*error=*/ null, /*remotePackage=*/ null);
             return;
         }
 
@@ -165,7 +166,7 @@ export class AcquisitionManager {
 
     public reportStatusDeploy(deployedPackage?: Package, status?: string, previousLabelOrAppVersion?: string, previousDeploymentKey?: string, callback?: Callback<void>): void {
         if (AcquisitionManager._apiCallsDisabled) {
-            console.log(`[CodePush] Api calls are disabled, skipping queryUpdateWithCurrentPackage`);
+            console.log(`[CodePush] Api calls are disabled, skipping reportStatusDeploy`);
             return;
         }
 
@@ -231,7 +232,7 @@ export class AcquisitionManager {
 
     public reportStatusDownload(downloadedPackage: Package, callback?: Callback<void>): void {
         if (AcquisitionManager._apiCallsDisabled) {
-            console.log(`[CodePush] Api calls are disabled, skipping queryUpdateWithCurrentPackage`);
+            console.log(`[CodePush] Api calls are disabled, skipping reportStatusDownload`);
             return;
         }
 

diff --git a/src/test/acquisition-sdk.ts b/src/test/acquisition-sdk.ts
@@ -227,6 +227,19 @@ describe("Acquisition SDK", () => {
         }));
     });
 
+    it("doesnt disable api calls on successful response", (done: Mocha.Done): void => {
+        var acquisition = new acquisitionSdk.AcquisitionManager(new mockApi.HttpRequester(), configuration);
+
+        acquisition.reportStatusDeploy(templateCurrentPackage, acquisitionSdk.AcquisitionStatus.DeploymentSucceeded, "1.5.0", mockApi.validDeploymentKey, ((error: Error, parameter: void): void => {
+            assert.strictEqual(acquisitionSdk.AcquisitionManager.apiCallsDisabled, false);
+        }))
+
+        acquisition.reportStatusDownload(templateCurrentPackage, ((error: Error, parameter: void): void => {
+            assert.strictEqual(acquisitionSdk.AcquisitionManager.apiCallsDisabled, false);
+        }));
+        done();
+    })
+
     it("disables api calls on unsuccessful response", (done: Mocha.Done): void => {
         var invalidJsonResponse: acquisitionSdk.Http.Response = {
             statusCode: 404,
@@ -237,27 +250,14 @@ describe("Acquisition SDK", () => {
 
         acquisition.queryUpdateWithCurrentPackage(templateCurrentPackage, (error: Error, returnPackage: acquisitionSdk.RemotePackage | acquisitionSdk.NativeUpdateNotification) => {
             assert.strictEqual(acquisitionSdk.AcquisitionManager.apiCallsDisabled, true);
-            done();
         });
 
         acquisition.queryUpdateWithCurrentPackage(templateCurrentPackage, (error: Error, returnPackage: acquisitionSdk.RemotePackage | acquisitionSdk.NativeUpdateNotification) => {
-            assert.strictEqual(returnPackage, undefined);
-            done();
+            assert.strictEqual(returnPackage, null);
         })
+        done();
     })
 
-    it("doesn't disable api calls on successful response", (done: Mocha.Done): void => {
-        var acquisition = new acquisitionSdk.AcquisitionManager(new mockApi.HttpRequester(), configuration);
-
-        acquisition.reportStatusDeploy(templateCurrentPackage, acquisitionSdk.AcquisitionStatus.DeploymentSucceeded, "1.5.0", mockApi.validDeploymentKey, ((error: Error, parameter: void): void => {
-            assert.strictEqual(acquisitionSdk.AcquisitionManager.apiCallsDisabled, false);
-        }))
-
-        acquisition.reportStatusDownload(templateCurrentPackage, ((error: Error, parameter: void): void => {
-            assert.strictEqual(acquisitionSdk.AcquisitionManager.apiCallsDisabled, false);
-            done();
-        }));
-    })
 });
 
 function clone<T>(initialObject: T): T {