Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added custom docker environment setting #60

Merged
merged 13 commits into from
Jan 10, 2022
Merged

added custom docker environment setting #60

merged 13 commits into from
Jan 10, 2022

Conversation

yvonnebarthp
Copy link
Contributor

No description provided.

mariamedp
mariamedp requested changes Dec 17, 2021
View reviewed changes
Copy link
Member

@mariamedp mariamedp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just a few small details

configuration/environments/environment_training_dockerfile/azureml_environment.json Outdated Show resolved Hide resolved
configuration/environments/environment_inference_dockerfile/azureml_environment.json Outdated Show resolved Hide resolved
configuration/environments/environment_inference_dockerfile/conda_dependencies.yml Outdated Show resolved Hide resolved
configuration/environments/environment_training_dockerfile/conda_dependencies.yml Outdated Show resolved Hide resolved
docs/how-to/AdjustingDockerfile.md Show resolved Hide resolved
yvonnebarthp
yvonnebarthp commented Dec 27, 2021
View reviewed changes
Copy link
Contributor Author

@yvonnebarthp yvonnebarthp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated naming conventions, versions, etc.

mariamedp
mariamedp reviewed Jan 10, 2022
View reviewed changes
docs/how-to/FAQ.md Outdated Show resolved Hide resolved
mariamedp
mariamedp previously approved these changes Jan 10, 2022
View reviewed changes
@mariamedp mariamedp self-requested a review January 10, 2022 08:50
@yvonnebarthp
Create FAQ.md
e35f9df 
Changed the path to AdjustingDockerfile.md
@yvonnebarthp
Update AdjustingDockerfile.md
b1dd664 
Changed link for "Configurations"
@mariamedp mariamedp merged commit b9aaf3c into main Jan 10, 2022
@mariamedp mariamedp deleted the feature/59-custom-docker branch January 10, 2022 09:52
@mariamedp mariamedp linked an issue Jan 10, 2022 that may be closed by this pull request
Add extra environment version with custom Docker image #59
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariamedp mariamedp mariamedp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add extra environment version with custom Docker image
2 participants
@yvonnebarthp @mariamedp