Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target based scaling support for MSSQL #169

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Add target based scaling support for MSSQL #169

merged 9 commits into from
Oct 10, 2024

Conversation

bachuv
Copy link
Contributor

@bachuv bachuv commented May 4, 2023 •
edited
Loading

This PR adds support for target based scaling. It builds upon Azure/azure-functions-durable-extension#2452. This PR is in draft mode since it hasn't been tested E2E yet.

Changes:

  • Add SqlMetricsProvider and move GetMetricsAsync() code from SqlScaleMonitor here
  • Add SqlTargetScaler (implements ITargetScaler)
  • Override TryGetTargetScaler in SqlDurabilityProvider
  • Add unit tests
  • E2E testing

@bachuv bachuv self-assigned this May 4, 2023
@davidmrdavid davidmrdavid mentioned this pull request May 11, 2023
Merged
13 tasks
@bachuv bachuv marked this pull request as ready for review May 17, 2023 19:25
@cgillum cgillum self-assigned this Oct 10, 2024
@cgillum
Copy link
Member

cgillum commented Oct 10, 2024

Quick note: I've successfully tested these changes in the Azure Functions SCv3 integration test code.

davidmrdavid
davidmrdavid reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, but overall looks great!

src/DurableTask.SqlServer.AzureFunctions/DurableTask.SqlServer.AzureFunctions.csproj Show resolved Hide resolved
src/DurableTask.SqlServer.AzureFunctions/SqlMetricsProvider.cs Outdated Show resolved Hide resolved
src/DurableTask.SqlServer.AzureFunctions/SqlScaleMonitor.cs Show resolved Hide resolved
test/DurableTask.SqlServer.AzureFunctions.Tests/TargetBasedScalingTests.cs Outdated Show resolved Hide resolved
test/DurableTask.SqlServer.AzureFunctions.Tests/TargetBasedScalingTests.cs Show resolved Hide resolved
@cgillum cgillum merged commit e477b00 into main Oct 10, 2024
2 checks passed
@cgillum cgillum deleted the vabachu/tbs branch October 10, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum left review comments

@davidmrdavid davidmrdavid davidmrdavid approved these changes

Assignees

@cgillum cgillum

@bachuv bachuv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bachuv @cgillum @davidmrdavid