Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent neutral button #1944

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Dec 14, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Added a new style to Button, transparentNeutral.

Binary change

Total increase: 168 bytes
Total decrease: -8 bytes

File Before After Delta
Total 30,922,584 bytes 30,922,744 bytes ⚠️ 160 bytes
Full breakdown
File Before After Delta
ButtonTokenSet.o 123,376 bytes 123,544 bytes ⚠️ 168 bytes
Button.o 211,080 bytes 211,072 bytes 🎉 -8 bytes

Verification

Visual Verification
Light Dark
light dark

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner December 14, 2023 00:51
@Saadnajmi
Copy link
Contributor

@mischreiber @huwilkes Are we ok with a new variant here?

@joannaquu joannaquu changed the title Add subtle neutral button Add transparent neutral button Dec 18, 2023
@anandrajeswaran
Copy link
Contributor

Should update PR description for the updated style name?

@joannaquu joannaquu merged commit 3053e63 into microsoft:main Dec 20, 2023
6 checks passed
@joannaquu joannaquu deleted the joannaqu/subtle-neutral branch February 6, 2024 21:12
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants