Respecting avatarOverrideStyle when setting TitleView style #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you provide some screen shots (from the fluent demo app) with this change on and off? |
owenconnolly
approved these changes
Jan 24, 2024
There is no example in the demo app to test avatar override style. After discussing with @alexanderboswell, we agreed I could merge this as it is and create a way to test this in a different change |
Addressing PR comments
alexanderboswell
approved these changes
Jan 24, 2024
joannaquu
approved these changes
Jan 24, 2024
mischreiber
reviewed
Jan 24, 2024
mischreiber
approved these changes
Jan 24, 2024
DanielMorM
added a commit
to DanielMorM/fluentui-apple
that referenced
this pull request
Jan 25, 2024
…t#1949) Respecting avatarOverrideStyle when setting TitleView style
DanielMorM
added a commit
that referenced
this pull request
Jan 25, 2024
Respecting avatarOverrideStyle when setting TitleView style
DanielMorM
added a commit
that referenced
this pull request
Jan 25, 2024
[Cherry Pick From Main] Respecting avatarOverrideStyle when setting TitleView style (#1949)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
When setting the TitleView style, the Avatar style was set not considering if there was an override already. This change is to consider the override when setting the AvatarStyle.
Verification
When setting an override style, the Avatar maintains the same style even when changing view controllers.
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow