Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore iOS AvatarTests #1964

Merged

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Feb 2, 2024

Platforms Impacted

  • iOS
  • macOS

Description of changes

  • Restoring AvatarTests.swift to our test package, updating the tests as needed for our new APIs.
  • Updating Avatar class to use some internal structures instead of private, allowing for deeper testability.
  • Enabling tests to run in the Swift package version of the library.

Binary change

Total increase: 0 bytes
Total decrease: -1,944 bytes

File Before After Delta
Total 31,053,920 bytes 31,051,976 bytes 🎉 -1,944 bytes
Full breakdown
File Before After Delta
FocusRingView.o 819,504 bytes 819,472 bytes 🎉 -32 bytes
__.SYMDEF 4,823,248 bytes 4,822,544 bytes 🎉 -704 bytes
Avatar.o 601,128 bytes 599,920 bytes 🎉 -1,208 bytes

Verification

All tests pass in both Xcode project and Swift package.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested review from a team as code owners February 2, 2024 21:40
@mischreiber mischreiber enabled auto-merge (squash) February 8, 2024 22:13
@mischreiber mischreiber merged commit 65a2c71 into microsoft:main Feb 9, 2024
7 checks passed
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants