Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TableViewCell backgroundConfiguration to reflect style #1981

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Feb 29, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

TableViewCell currently uses UIBackgroundConfiguration.clear() regardless of what style the cell is. This is fine on iOS. On visionOS, this means that plain cells have rectangular corners when they should have rounded ones. Update backgroundConfiguration to reflect the cell style.

Binary change

(This feels wrong to me but I double checked it)

Total increase: 104 bytes
Total decrease: -21,464 bytes

File Before After Delta
Total 30,908,368 bytes 30,887,008 bytes 🎉 -21,360 bytes
Full breakdown
File Before After Delta
PersonaCell.o 62,744 bytes 62,848 bytes ⚠️ 104 bytes
FocusRingView.o 815,288 bytes 815,176 bytes 🎉 -112 bytes
__.SYMDEF 4,774,672 bytes 4,772,600 bytes 🎉 -2,072 bytes
TableViewCell.o 812,456 bytes 809,560 bytes 🎉 -2,896 bytes
BooleanCell.o 89,864 bytes 86,400 bytes 🎉 -3,464 bytes
BottomCommandingController.o 846,336 bytes 842,832 bytes 🎉 -3,504 bytes
PersonaListView.o 185,616 bytes 182,072 bytes 🎉 -3,544 bytes
PopupMenuItemCell.o 176,080 bytes 170,208 bytes 🎉 -5,872 bytes

Verification

Visual Verification
Before After
before after
plain light before plain light after
plain dark before plain dark after
grouped light before grouped light after
grouped dark before grouped dark after
override before override after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner February 29, 2024 04:14
@joannaquu joannaquu changed the title update backgroundConfiguration Update TableViewCell backgroundConfiguration to reflect style Feb 29, 2024
@joannaquu joannaquu merged commit d1eb748 into microsoft:main Mar 1, 2024
7 checks passed
@joannaquu joannaquu deleted the joannaqu/cell-background branch March 1, 2024 01:02
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants